Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footprint conv2d #1

Merged
merged 2 commits into from Oct 26, 2020
Merged

Footprint conv2d #1

merged 2 commits into from Oct 26, 2020

Conversation

Ngoguey42
Copy link
Collaborator

@Ngoguey42 Ngoguey42 commented Nov 9, 2019 •
edited

Please review :)

@Ngoguey42 Ngoguey42 mentioned this pull request Dec 5, 2019
Merged
@Ngoguey42
Copy link
Collaborator Author

Ngoguey42 commented Aug 12, 2020 •
edited

Let's merge this PR @azarz @Evenfire !
I've split it into 2 distinct PRs. See #4

@Ngoguey42 Ngoguey42 force-pushed the footprint-conv2d branch 2 times, most recently from ef9dbb9 to 8aea618 Compare August 12, 2020 10:34
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1 into master will increase coverage by 0.00%.
The diff coverage is 89.32%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   91.90%   91.91%           
=======================================
  Files          68       68           
  Lines        5496     5589   +93     
=======================================
+ Hits         5051     5137   +86     
- Misses        445      452    +7
Impacted Files Coverage Δ
buzzard/_footprint.py 81.90% <89.32%> (+0.70%) ⬆️
buzzard/_env.py 90.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3196093...7dfad96. Read the comment docs.

@Ngoguey42 Ngoguey42 merged commit a93081c into master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azarz azarz azarz approved these changes

@Evenfire Evenfire Awaiting requested review from Evenfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ngoguey42 @azarz