Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For quality checks reference should be taken from actual PyTorch version of model #162

Closed
Anindyadeep opened this issue Apr 9, 2024 · 1 comment
Closed

For quality checks reference should be taken from actual PyTorch version of model #162

Anindyadeep opened this issue Apr 9, 2024 · 1 comment

Comments

@Anindyadeep
Copy link
Member

In order to do quick emprical testing, the ground truth of the model should be the model output from the raw float32 weights, which can be done from HF Transformers.
@Anindyadeep Anindyadeep changed the title For quality checks reference should be taken from actual pytorh version of model For quality checks reference should be taken from actual PyTorch version of model Apr 13, 2024
This was referenced Apr 13, 2024
Merged
Closed
@Anindyadeep
Copy link
Member Author

Issue has been resolved through PR #167 and #116. So now we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anindyadeep