-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Mistral in HF Transformers with Quality comparison README and Logging Improvements #167
Conversation
…k performance logs in templates
@Anindyadeep I've created a dev branch where you can create all the PRs and then once everything is done we can merge dev into main. Can you update the PRs against dev? |
Awesome, I changed this PR to |
This PR Adds some improvements to
Please note (Proposal):
We should Merge this PR to a different staging branch. Reason being, README will be broken after this which can also reflect in main branch. And since we changed the model from Llama 2 to LLama 2 Chat, we get bit different results. So proposal is, up next all the PRs, gets merged under staging branch. Once most of all the benchmarks are added, we can merge staging to main.
Update:
There are some improvements introduced in this PR for Logging (under
utils.py
) Where the main focus was the following:quality.json
was taking redundant valuesquality.md
README fromquality.json
. The reason being, it is super hard to copy paste the output in readme manually, so better to copy paste the generated README.This PR also solves issues #162 #157