Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider creating #eq handlebars helper directly instead of relying on handlebars-helpers project #35

Closed
rootwork opened this issue Jun 24, 2021 · 4 comments
Closed

Consider creating #eq handlebars helper directly instead of relying on handlebars-helpers project #35

rootwork opened this issue Jun 24, 2021 · 4 comments
Labels
Status: Abandoned No activity, considered abandoned. Status: Done Completed. Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability.

Comments

@rootwork
Copy link
Member

rootwork commented Jun 24, 2021 •
edited

The project hasn't been updated in 4+ years; it depends on helpers-markdown which is pinned to a depreciated version of highlight.js that prints big warnings on install.

Also, what we need it for is tiny. Let's get rid of the library and just include an #eq helper directly.
@rootwork rootwork changed the title Consider creating #if handlebars helper directly instead of relying on handlebars-helpers project directly Consider creating #if handlebars helper directly instead of relying on handlebars-helpers project Jul 30, 2021
@rootwork
Copy link
Member Author

Also maybe relevant? https://cloudfour.com/thinks/the-hidden-power-of-handlebars-partials/

@rootwork rootwork changed the title Consider creating #if handlebars helper directly instead of relying on handlebars-helpers project Consider creating #eq handlebars helper directly instead of relying on handlebars-helpers project Sep 9, 2021
@rootwork
Copy link
Member Author

rootwork commented Sep 9, 2021

https://code-maven.com/handlebars-conditionals

rootwork added a commit that referenced this issue Sep 9, 2021
@rootwork
Removing handlebars-helpers package in favor of simple 'eq' helper. F…
25b4f98 
…ixes #35

Signed-off-by: Ivan Boothe <ivan@rootwork.org>
@rootwork
Copy link
Member Author

rootwork commented Sep 9, 2021

Well that was easy.

@rootwork rootwork closed this as completed Sep 9, 2021
@rootwork rootwork added performance Status: Done Completed. Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability. labels Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Issue closed and locked due to lack of activity.
If you encounter this same issue, please open a new issue and refer to this closed one.

@github-actions github-actions bot added the Status: Abandoned No activity, considered abandoned. label Nov 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Abandoned No activity, considered abandoned. Status: Done Completed. Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability.
Projects
Premail 2.x (current)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootwork