Add support for background-size in the shorthand property #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The “background” property supports background size in addition to the other long-form properties. When we have a separate “background-size” property and when we create a shorthand version, we must include the background-size in the shorthand by preceding it with a slash: / And vice versa—when we’re parsing a shorthand property, we must look for and fetch the “background-size” before we extract “background-position” as otherwise it might be ambiguous.
grosser
added a commit
that referenced
this pull request
Mar 16, 2016
Add support for background-size in the shorthand property
|
thx, 1.4.0 is out! |
|
Just fyi, I had been working on a fix for this today, and a background shorthand with size cannot be read by yahoo mail. Not sure if you guys are worried about those kind of vendor-specific issues though. |
|
@mkigikm I think that when you "compact" a bunch of properties into their shorthand, you should try to comply with the standards, meaning that if there's a background-size, you should put it there (unless you make it important in which case it will stay as a standalone one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backgroundproperty supports background size in addition to the other long-form properties. When we have a separatebackground-sizeproperty and when we create a shorthand version, we must include thebackground-sizein the shorthand by preceding it with a slash:/and vice versa—when we’re parsing a shorthand property, we must look for and fetch thebackground-sizebefore we extractbackground-positionas otherwise it might be ambiguous.This should fix premailer/premailer#252 and premailer/premailer#216.