Fixed various issues with escaping in CodeLite generator #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdesveauxPKFX
approved these changes
May 1, 2019
modules/codelite/codelite.lua
Outdated
| function codelite.esc(value) | ||
| local result = value:gsub('&', '&') | ||
| result = result:gsub('<', '<') | ||
| result = result:gsub('>', '>') | ||
| result = result:gsub('"', '"') |
There was a problem hiding this comment.
Do you see further divergence that would prevent esc calling escElementText?
There was a problem hiding this comment.
I wanted to err on the side of caution with this, the escaping seems to be very fragile and inconsistent in CodeLite and I wanted to avoid future issues. For example, not escaping quotes results in the cURL project to silently fail to load in the Premake workspace - I believe there's another project that fails too.
samsinsane
force-pushed
the
ssurtees/codeliteFixes
branch
from
7f6558c
to
84c6049
Compare
samsinsane
commented
May 2, 2019
samsinsane
force-pushed
the
ssurtees/codeliteFixes
branch
from
84c6049
to
4531b0d
Compare
|
What about merging? CodeLite generator broken. |
|
@tdesveauxPKFX I made more changes since you last reviewed, but I'm going to merge this since as @alex-rass-88 has pointed out the generator is broken without these fixes. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.