Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update D module to VS2019 and latest D compiler options. #1298

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Update D module to VS2019 and latest D compiler options. #1298

merged 1 commit into from
Jun 3, 2019

Conversation

TurkeyMan
Copy link
Contributor

Been meaning to get to this for ages.

starkos
starkos approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the D expert! It looks fine to me overall, open to discussion about how to improve the use of toolset.

@starkos starkos merged commit d561c80 into premake:master Jun 3, 2019
@TurkeyMan
Copy link
Contributor Author

TurkeyMan commented Jun 4, 2019 •
edited

Yeah I dunno, I opened an issue about that a while ago to start discussion. The toolset issue is kinda problematic; premake is kinda incompatible with mixed-language projects for that reason.
Maybe you could filter it by language or something, but that feels really problematic.
Could use parallel API's for different language toolsets, but that feels crappy as well. Not sure.

@TurkeyMan TurkeyMan deleted the d_updates branch June 4, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkos starkos starkos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TurkeyMan @starkos