On OSX, convert systemversion to MACOSX_DEPLOYMENT_TARGET #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the discussion in issue premake#1336, if systemversion is set output MACOSX_DEPLOYMENT_TARGET into the resulting xcode project. This borrows a diff from the (unmerged) PR premake#1003, applies it in isolation, and adds a pair of unit tests to confirm that both setting and not setting the systemversion results in correct output. Closes premake#1336
|
Hey awesome! Thank you for merging. Out of curiosity: how often do you rev binaries? I guess this will be in premake5 alpha15 but curious what the ship date for that is (if you have one). Appreciate the merge! |
Unfortunately, we don't have any particular schedule for releases, it's more of a "when there's time" kind of thing at the moment. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in issue #1336, if systemversion is set
output MACOSX_DEPLOYMENT_TARGET into the resulting xcode project.
This borrows a diff from the (unmerged) PR #1003, applies it
in isolation, and adds a pair of unit tests to confirm that both
setting and not setting the systemversion results in correct
output
There is one situation where this could break a user's premake. If they set a systemversion globally and built only on windows and mac, right now that global systemversion would be ignored on mac; but after this change that systemversion will need to be OS-scoped.
Since this is my first pull request, I am sure you'll have lots of feedback. I'm happy to change whatever you think is appropriate! I checked the contrib guidelines and I think I got everything but want to make sure this works for you all.
Thanks so much!
Closes #1336
closes #XXXXin comment to auto-close issue when PR is merged)