Initial support for generating netcore and netstandard projects #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starkos
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #1010
This adds support for generating netcore and netstandard projects via the dotnetframework property. It also adds support for the property used to enable WPF.
How does this PR change Premake's behavior?
I've added a new method in dotnetbase called "isNewFormatProject". This is used to control the differences between .NET Framework and netcore/netstandard projects. Rather than keep a list of all frameworks, it determines any version starting with "netcoreapp" or "netstandard" should use the new project format rules. This method will need to be updated once .NET 5 is released as it's very likely to use the netcore format.
Anything else we should know?
This changelist does not add support for targetting multiple frameworks. It should be easy to do, but I'd prefer to add it to another PR as I'm not sure how to test it.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!