Fixed bug with linkgroups only working on Premake projects #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starkos
approved these changes
Feb 3, 2020
starkos
approved these changes
Feb 3, 2020
Oops, I'll do that when I get a chance - hopefully tomorrow night. |
samsinsane
force-pushed
the
ssurtees/linkgroupsFix
branch
from
8c17f4b
to
f8a88c3
Compare
|
@starkos I've added a test for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
linksgroupsnow applies to alllinksinstead of just the Premake projects. Closes #1265How does this PR change Premake's behavior?
I don't believe there's any breaking change, projects will now link correctly to external libraries.
Anything else we should know?
None
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!