Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .c++ extension support to a few spots it was missing #1415

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

englercj
Copy link
Contributor

What does this PR do?

Attempts to add full support for the .c++ extension.

How does this PR change Premake's behavior?

Files with the .c++ extension seemed to be partial supported before, but this should shore up a few missing places. For example, iscpp returned true for .c++ files but they were not marked for compilation.

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@englercj
Copy link
Contributor Author

Ping @TurkeyMan, related to a convo we had today.

@samsinsane samsinsane merged commit c4f3603 into premake:master Mar 28, 2020
@englercj englercj deleted the c++-ext-support branch March 28, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants