Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable enablewarnings() for MSC #1421

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

starkos
Copy link
Member

@starkos starkos commented Apr 6, 2020

What does this PR do?

Adds support for Premake's enablewarnings() call to MSC and Visual Studio. From the original pull request: "This pull request makes it so any warnings that are specifically enabled are set to level 1, which enables them as long as the user has the warning level at least level 1."

h/t @TrianglesPCT for the idea.

How does this PR change Premake's behavior?

Values set for enablewarnings() will now be applied to the MSC switches. This may cause a change in behavior if warnings had been previously enabled but ignored.

Anything else we should know?

No.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (n/a)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@starkos starkos mentioned this pull request Apr 6, 2020
5 tasks
@starkos
Copy link
Member Author

starkos commented Apr 6, 2020

Not sure why some CI builds see the branch and others don't?

@samsinsane
Copy link
Member

This looks like you've got CI setup on your fork, but it's using this repos details instead of your fork? I'm guessing you would just need to disable the CI configuration in your repo?

@starkos starkos merged commit 3b5f6e6 into premake:master Apr 7, 2020
@starkos starkos deleted the feature/vs-enablewarnings branch April 7, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants