Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions #1422

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

samsinsane
Copy link
Member

What does this PR do?

This adds GitHub Actions to do CI as a potential replacement for both Travis-CI and AppVeyor.

How does this PR change Premake's behavior?

N/A.

Anything else we should know?

Windows builds use windows-msbuild instead of windows, the upgrade is unnecessary.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramping up on Workflows now, approving in the meantime.

@starkos starkos merged commit 71156f3 into premake:master Apr 15, 2020
@samsinsane samsinsane deleted the ssurtees/githubActions branch April 15, 2020 16:21
@samsinsane
Copy link
Member Author

samsinsane commented Apr 15, 2020

Hmm, it doesn't appear to have done a master build, I must have got something wrong. Pushing branches worked in my fork, and I assume PRs will work since it does specify them the same way as pushing, I guess neither are merges? I'll look into this when I get a chance 👍

Edit: I guess I spoke too soon, the PR I just merged triggered a CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants