Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed adding LD_LIBRARY_PATH to the executable run command. #1430

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fixed adding LD_LIBRARY_PATH to the executable run command. #1430

merged 1 commit into from
Apr 26, 2020

Conversation

Enhex
Copy link
Contributor

@Enhex Enhex commented Apr 26, 2020

What does this PR do?

Fix Codelite generator creating broken executable run command.
Premake wrongly adds libdirs to Project Settings -> General -> Executable to Run / Debug.

Anything else we should know?

libdirs are already added to Project Settings -> Linker -> Libraries Search path.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

@samsinsane
Copy link
Member

This looks like it just reverts #1206 with #1201 being the original PR. Can you please elaborate on why this is wrong?

@Enhex
Copy link
Contributor Author

Enhex commented Apr 26, 2020

It simply adds libdirs to the executable run command, for example:

Executing: cmd /C  call "\\LD_LIBRARY_PATH=E\conan\Celero\master\enhex\stable\package\3fb49604f9c2f729b85ba3115852006824e72cab\lib bin\Release\search.exe" && pause

Obviously that doesn't work, it should be:

Executing: cmd /C  call "bin\Release\search.exe" && pause

I tried it with Codelite 13 & 14.

You can easily reproduce it by generating Codelite project from a Premake executable script with libdirs defined.
I recommend trying this on Linux (can use a Virtual Machine) because setting up Codelite on Windows doesn't work well.

Also I don't understand why it was added in the first place.

@samsinsane
Copy link
Member

Are you saying that the LD_LIBRARY_PATH also failed when you tried this on Linux? Can you provide the snippet of what CodeLite was going to execute on Linux?

@Enhex
Copy link
Contributor Author

Enhex commented Apr 26, 2020

in Codelite's output tab:
Executing: /usr/bin/codelite-terminal --working-directory=/home/desktop/dev/Benchmarks/build/search --file=/tmp/CodeLite.desktop.1587896503/codelite-terminal.txt --wait

And in the run console:
/bin/bash: /home/desktop/dev/Benchmarks/.conan/data/Celero/master/enhex/stable/package/2a30b7d6ea2202e5393ebda51c8729dd2162b9f8/lib bin/Release/search: No such file or directory

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on discussion - looks like the changes from the previous PR no longer work with latest CodeLite.

@samsinsane samsinsane merged commit 5d0b64c into premake:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants