Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sysincludedirs for codelite. #1505

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Fix sysincludedirs for codelite. #1505

merged 2 commits into from
Aug 30, 2020

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Aug 29, 2020 •
edited

What does this PR do?

Implement sysincludedirs for codelite.

How does this PR change Premake's behavior?

No changes in Premake core. only in codelite generator.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

samsinsane
samsinsane requested changes Aug 30, 2020
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding new functionality, you add new tests - you don't just hijack existing tests.

modules/codelite/tests/test_codelite_config.lua Outdated Show resolved Hide resolved
modules/codelite/tests/test_codelite_config.lua Show resolved Hide resolved
@samsinsane samsinsane merged commit 14185d4 into premake:master Aug 30, 2020
@Jarod42 Jarod42 deleted the sysincludedirFixForCodelite branch August 30, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jarod42 @samsinsane