Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable network tests; add --test-all flag to enable #1532

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

starkos
Copy link
Member

@starkos starkos commented Oct 7, 2020

What does this PR do?

Hides the automated tests that require calls out to the network behind a new --test-all flag. Allows for faster TDD iterations for new development, and tests can now be run even when offline.

How does this PR change Premake's behavior?

Tests which require network access (HTTP, NuGet) will no longer run by default.

Anything else we should know?

I added the --test-all flag to the GitHub CI action, so we'll still be running them there. Open to discussion on whether that's a good idea or not.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Hides the automated tests that require calls out to the network behind a new `--test-all` flag. Allows for faster TDD iterations for new development, and tests can now be run even when offline.
@samsinsane samsinsane merged commit 0bf4fb6 into premake:master Oct 8, 2020
@starkos starkos deleted the exclude-net-tests branch March 16, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants