Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API to disable fast up to date checks #1555

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

nickclark2016
Copy link
Member

@nickclark2016 nickclark2016 commented Nov 5, 2020

What does this PR do?

Adds DisableFastUpToDateCheck API, which is only useful for Visual Studio projects. When fastuptodate is Disable, it adds the relevant XML entry to the globals property group. Closes #1443.

How does this PR change Premake's behavior?

No changes to existing behavior. Adds XML entries when fastuptodate is set to Disable.

Anything else we should know?

API:

project "name"
    -- To Disable
    fastuptodate "Off"

    -- To Enable
    fastuptodate "On" -- does nothing, added for completeness

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

src/_premake_init.lua Outdated Show resolved Hide resolved
modules/vstudio/vs2010_vcxproj.lua Outdated Show resolved Hide resolved
modules/vstudio/vs2010_vcxproj.lua Outdated Show resolved Hide resolved
modules/vstudio/vs2010_vcxproj.lua Outdated Show resolved Hide resolved
Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll return the apology for the slow turnaround. Can you rebase this against the current main branch and I'll go ahead and merge?

@nickclark2016
Copy link
Member Author

I hit update. I think that rebases. If not, feel free to let me know and I'll manually rebase.

@starkos starkos dismissed samsinsane’s stale review April 19, 2021 14:51

Change has been made as requested

@starkos starkos merged commit fae76cb into premake:master Apr 19, 2021
@starkos
Copy link
Member

starkos commented Apr 19, 2021

Thanks for the quick follow up!

@nickclark2016 nickclark2016 deleted the issues/1443 branch August 25, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there API for generating custom XML entries in VS project files?
3 participants