Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out community section on website #1604

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

starkos
Copy link
Member

@starkos starkos commented Mar 26, 2021

What does this PR do?

Moves community-related website content out of the 5.x specific docs and into its own top-level area.

How does this PR change Premake's behavior?

No changes to Premake code, just the website.

Anything else we should know?

Addresses a portion of the work required to resolve #1547.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@starkos starkos requested a review from KyrietS March 26, 2021 13:56
Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with making a new folder for community stuff 👍

While you are moving showcase I checked the links there so you can update the list according to my suggestions. In any case I consider this PR approved 🥇

By the way, I don't know why CI tests for binary are yellow. They should be skipped (because of paths-ignore) but they are marked as "expected"/"required" 🤔 Master branch is protected and maybe there is some kind of setting that makes those tests "required"?

website/community/showcase.md Outdated Show resolved Hide resolved
website/community/showcase.md Show resolved Hide resolved
@KyrietS
Copy link
Member

KyrietS commented Mar 26, 2021

Ok, I got it. In the repo's settings there is a rule for master branch that those tests are necessary to merge. In this situation I suggest removing:

on:
  push:
    paths-ignore: ['website/**']
  pull_request:
    paths-ignore: ['website/**']

and going back to:

on: [push, pull_request]

Tests for binaries are fast enough so it won't be a problem anyway.

@starkos
Copy link
Member Author

starkos commented Mar 29, 2021

I fixed the links and the CI configuration as requested, and also switched to a nicer (IMHO) widget for displaying the sponsors on the download page.

@starkos starkos merged commit 13567cd into premake:master Mar 30, 2021
@starkos starkos deleted the website-community-pages branch March 30, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation hosting
2 participants