Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new user website navigation #1610

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

starkos
Copy link
Member

@starkos starkos commented Apr 6, 2021

What does this PR do?

Make a few improvements to the website navigation:

  • Add GitHub & Twitter links to the navbar
  • Clean up and improve footer links
  • Improve the flow of the intro pages
  • Fix broken link on Building Premake
  • Use a proper favicon
  • Add OS icons on download page

How does this PR change Premake's behavior?

Website only; no Premake code changes.

Anything else we should know?

See #1547 for all the website setup discussion.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great commit! 😃
Please address my first comment about unused field. The other one is just a side note :-)

website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Show resolved Hide resolved
@starkos starkos merged commit 8715807 into premake:master Apr 10, 2021
@starkos starkos deleted the website-nav-cleanup branch April 10, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants