Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "support" for kind "None" (as do nothing) for gmake/gmake2. #1757

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Nov 18, 2021

What does this PR do?

Add "support" for kind "None" (as do nothing) for gmake/gmake2.

How does this PR change Premake's behavior?

Just change gmake/gmake2 generators.

Anything else we should know?

closes #1149
Tested also with my testing repo https://github.com/Jarod42/premake-sample-projects/tree/GMakeKindNone

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving!

@starkos starkos merged commit 81460b4 into premake:master Nov 21, 2021
@Jarod42 Jarod42 deleted the GMakeKindNone branch November 22, 2021 08:30
@RicoP
Copy link

RicoP commented Oct 1, 2022

Just saw this PR closing my bug report from 4 years ago! good work :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kind "None" doesn't build on Linux
3 participants