Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unavailable modules #1787

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

KyrietS
Copy link
Member

@KyrietS KyrietS commented Jan 4, 2022

What does this PR do?

Removes links to modules resulting with 404.

I wonder if it would be better to link @Jarod42's fork instead of the original CMake module. As far as I know, the fork fixes several bugs?

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@KyrietS
Copy link
Member Author

KyrietS commented Jan 5, 2022

Poking @Enhex for reference as he's the author of the premake-cmake module.

@Enhex
Copy link
Contributor

Enhex commented Jan 5, 2022

Note that I'm not actively maintaining the CMake generator.
I experimented with several IDEs on Linux and wrote Premake generators to try them, and now I
only maintain generators I use.

So maybe there's a fork of my repo that's more active, in which case it should be referred to instead.

@Jarod42
Copy link
Contributor

Jarod42 commented Jan 6, 2022

On my side, I created generic integration tests for Premake's generators, and just testing the generators which seems important (as CMake's one).
I indeed fix those which fail my tests (and create PRs) (Authors of premake-ninja even gave me rights to modify repository directly).
Whereas I might fix issues encountered with my tests, I don't think I will go further for my forks.

@KyrietS
Copy link
Member Author

KyrietS commented Jan 6, 2022

Alright, considering both statements I decided to link @Jarod42's fork. It has a few more features, and the original repo is tagged on GitHub anyway. This list is very "community driven" and neither of you should feel obligated to maintain these modules ofc.

@samsinsane samsinsane merged commit 9d38e82 into premake:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants