Added Unit Test for Workspace Generation #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclark2016
force-pushed
the
issues/1876-followup
branch
from
d73170d
to
4d98936
Compare
|
This is a follow on to that PR. Had ported my changes back from my 6.x working area, and noticed a few differences in v5 that needed clean up and a unit test. Should be g2g with this. I'll close on Monday or Tuesday unless someone has comments or closes before me. |
samsinsane
reviewed
May 16, 2022
nickclark2016
force-pushed
the
issues/1876-followup
branch
2 times, most recently
from
c057afb
to
5c12218
Compare
samsinsane
approved these changes
May 16, 2022
nickclark2016
force-pushed
the
issues/1876-followup
branch
from
5c12218
to
9e34852
Compare
|
Okay, I think I've got the major test cases covered for spaces in the path and the project file name, just let me know if you want me to put in any more cases before we merge this in. |
samsinsane
approved these changes
May 16, 2022
|
Thanks again for the review. I'm gonna leave it open until the end of the day for comments, then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1876.
What does this PR do?
Adds unit test, makes sure all escaping uses p.esc in the gmake workspace generation.
How does this PR change Premake's behavior?
N/A
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!