New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `premake.findProjectScript` of previous commit. #2122

Merged

nickclark2016 merged 1 commit into premake:master from Jarod42:includeFix

Aug 17, 2023

Contributor

Jarod42 commented Aug 10, 2023

What does this PR do?

Did you check all the boxes?

Focus on a single fix or feature; remove any unrelated formatting or code changes
Add unit tests showing fix or feature works; all tests pass
Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
Follow our coding conventions
Minimize the number of commits
Align documentation to your changes

Jarod42 mentioned this pull request

Revert "Improve error message of include #2120

Closed

nickclark2016 reviewed

View reviewed changes

Member

nickclark2016 left a comment

Just a minor nit, can we give f a more descriptive name? Other than that, LGTM.

Contributor Author

Jarod42 commented Aug 16, 2023

Any proposal?
compiled_chunk, func, chunk_func?

Member

nickclark2016 commented Aug 16, 2023

Either the first or last is fine to me. Just something that gives me an idea of what's going on if I've gotta touch that code in the future.


          Fix premake.findProjectScript of previous commit.

de57822

Jarod42 force-pushed the includeFix branch from e89a44b to de57822 Compare

August 17, 2023 01:08

Contributor Author

Jarod42 commented Aug 17, 2023

Renamed to compiled_chunk.

nickclark2016 approved these changes

View reviewed changes

Member

nickclark2016 commented Aug 17, 2023

Just a sanity check, but this is verified, correct?

Contributor Author

Jarod42 commented Aug 17, 2023

Verified locally and with: premake-sample-projects/actions (Test fix for premake master.)
(Whereas premake5-ubuntu-gmake show the issue).

nickclark2016 merged commit ef7baca into premake:master

12 checks passed

Jarod42 deleted the includeFix branch

August 17, 2023 15:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment