Add text block edit functionality #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrnossiom is attempting to deploy a commit to the Premier Octet Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Feature needed! 🙏 Thanks @mrnossiom |
|
Hello @mrnossiom! We have slightly updated the UI related to your PR, see #15 |
mrnossiom
force-pushed
the
feat/add-text-block-edit-functionality
branch
from
4e01324
to
cfa28ab
Compare
|
I changed the button label of the |
baptadn
requested changes
Sep 15, 2023
Co-authored-by: Baptiste Adrien <adrien.baptiste@gmail.com>
Co-authored-by: Baptiste Adrien <adrien.baptiste@gmail.com>
|
Thanks @mrnossiom! I have spot a bug, when the user edits the text and re-edit, the textarea still contains the old text : Kapture.2023-09-15.at.19.00.56.mp4 |
Good catch 👍🏻 |
|
Thanks a lot @mrnossiom! |
baptadn
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻,
To add the ability of editing text blocks, I quickly duplicated the
EditBookmarkCardfile and modified the.../{digestId}/block/{blockId}endpointPATCHimplementation. Adding anonEditClickprop to theBlockTextCardcomponent to show theEditbutton in the Block Menu Popover.Didn't test intensively, but it should work fine 😄
Improvements
AddTextBlockDialogandEditTextBlockDialoginto one component?.../{digestId}/block/{blockId}file to avoid nesting. Factorizeif-elsestatement in functions?