Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimistic update #71

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: optimistic update #71

merged 1 commit into from
Nov 3, 2023

Conversation

tlenclos
Copy link
Contributor

@tlenclos tlenclos commented Nov 3, 2023

Right now we got a stale value in optimistic update when inviting a new member so the UI doesn't refresh, the invitation props data are good though.

See vercel/next.js#57662

@tlenclos tlenclos requested a review from Lucieo November 3, 2023 10:01
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digestclub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 10:06am

@tlenclos tlenclos merged commit 797fd42 into main Nov 3, 2023
3 checks passed
@tlenclos tlenclos deleted the fix/optimistic-update branch November 3, 2023 13:48
@Feel-ix-343
Copy link

Hey I have this issue as well. Did you ever figure it our or did you just remove optimistic updates entirely?

@tlenclos
Copy link
Contributor Author

We kept this fix that removed the optimistic update, it was just an improvement anyway :)
I saw that you found the root of the issue here also facebook/react#27617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants