Adds external id field to generic invoice entry #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this field to hold a reference passed by the clients of the lib to allow the identification of a given entry and match it to a representation held in the client
mabrcosta
requested changes
Jan 8, 2024
.../main/java/com/premiumminds/billy/persistence/entities/jpa/JPAGenericInvoiceEntryEntity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/premiumminds/billy/persistence/entities/jpa/JPAGenericInvoiceEntryEntity.java
Outdated
Show resolved
Hide resolved
Replace toString with getIdentifier to avoid possible overrides and implementation changes associated with toString Replace Optional.of() with Optional.ofNullable() to avoid potential problems with cases where we don't have an external id. Associated with this, improve ExternalID implementation to return null when a null value is passed to fromValue(...).
mabrcosta
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this field to hold a reference passed by the clients of the lib to allow the identification of a given entry and match it to a representation held in the client