Added flush to encode() method to write remaining bits #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stream" This reverts commit 08ba18c.
forgot to commit the place where the flush is actually called
A library should never print to System.err or System.out. Instead a logging framework shoul dbe used.
The BMP sample testcase was failing because my GitHub application puts its projects into "c:\Users\myuser\My Documents". The blank in "My Documents" was converted into a "%20" when using the getFile method.
thorstenfrank
pushed a commit
to thorstenfrank/preon
that referenced
this pull request
May 26, 2018
|
The actual fix has been applied. The printStackTrace calls should be rempved by another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the changes