Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two year old typo + smart tool #23

Closed
szepeviktor opened this issue Sep 13, 2019 · 2 comments · Fixed by #24
Closed

Two year old typo + smart tool #23

szepeviktor opened this issue Sep 13, 2019 · 2 comments · Fixed by #24

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Sep 13, 2019 •
edited
Loading

@phpstan reveals hard and soft errors! Please consider using it phpstan analyze source/ -l max

pre-plugin/source/Parser.php

Lines 18 to 23 in bd21e7d

private $macro = [];
private $compilers = [];
public function addMacro($macro)
{
$this->macros[$macro] = true;

@szepeviktor szepeviktor changed the title Big typo + smart tool Two year old typo + smart tool Sep 13, 2019
szepeviktor added a commit to szepeviktor/pre-plugin that referenced this issue Sep 13, 2019
@szepeviktor
Fix typeo in Parser
d226824 
discovered by @phpstan
Fixes preprocess#23
@szepeviktor szepeviktor mentioned this issue Sep 13, 2019
Merged
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 17, 2019 •
edited
Loading

@assertchris Have you tried @phpstan?

@assertchris
Copy link
Member

Not for this repo, but I guess I should :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in Parser szepeviktor/pre-plugin
2 participants
@assertchris @szepeviktor