Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
On MacOs the Chrome would not start, shell command ran but exited:
The reason:
The backslashes in -
/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome
are not interpreted as literal characters by JS, but rather ignored and the resulting JS string was:/Applications/Google Chrome.app/Contents/MacOS/Google Chrome
.Fix:
To resolve this, we need to escape whitespaces as we would escape them in a shell command, by wrapping it in double quotes:
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
Related: nodejs/node#7367 (comment)
Tested on:
MacOS: 13.2.1
NodeJS: v14.21.3