feat(types): tighten up the types of callFirestore calls #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using function overloading, define separate call types for the different actions of the callFirestore() method. Then use the built-in Firestore type declarations to tighten up the argument types for set/add/update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 6 6
Lines 289 289
Branches 108 108
=======================================
Hits 252 252
Misses 11 11
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
Nice! Love the separation of the different actions into their own types! Since this is just making types more accurate, but is still changing the external facing types, so I'm going to mark as |
prescottprue
changed the title
prescottprue
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using function overloading, define separate call types for the different actions of the
callFirestore()method. Then use the built-in Firestore type declarations to tighten up the argument types for set/add/update etc.Fixes #1172