Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(types): populates is missing from ReduxFirestoreQuerySetting interface #1027

Closed
keithkelly31 opened this issue Nov 19, 2020 · 1 comment
Closed

bug(types): populates is missing from ReduxFirestoreQuerySetting interface #1027

keithkelly31 opened this issue Nov 19, 2020 · 1 comment
Labels
bug types Changes associated with typescript types

Comments

@keithkelly31
Copy link

When using useFirestoreConnect in a js or jsx file it works as expected. When working in typescript I receive an error:

'populates' does not exist in type 'ReduxFirestoreQuerySetting | ReduxFirestoreQuerySetting[] | string[] | mapper<unknown, (string | ReduxFirestoreQuerySetting)[]> | mapper<...>'.ts(2345)

Can populates be added to the proper types?
@prescottprue prescottprue added types Changes associated with typescript types bug labels Nov 22, 2020
@prescottprue prescottprue changed the title Add populates to the ReduxFirestoreQuerySetting interface bug(types): populates is missing from ReduxFirestoreQuerySetting interface Nov 22, 2020
prescottprue added a commit that referenced this issue Nov 23, 2020
@prescottprue
fix(types): add types for handleRedirectResult and reauthenticate met…
959884c 
…hods - #987

* fix(types): add populates to query settings types - #1027
@prescottprue prescottprue mentioned this issue Nov 23, 2020
Merged
3 tasks
prescottprue added a commit that referenced this issue Nov 23, 2020
@prescottprue
v3.8.1 (#1029)
6786fdc 
* fix(query): handle un-mounting with no listeners - #1019
* fix(types): add types for `handleRedirectResult` and re-authenticate methods - #987
* fix(types): add `populates` to query settings types - #1027
* fix(ci): remove usage of set-env from publish workflow (deprecated)
@prescottprue
Copy link
Owner

The v3.8.1 release includes a fix for this. Reach out if it isn't working as expected thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug types Changes associated with typescript types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prescottprue @keithkelly31