Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase database ref #28

Closed
DeividasK opened this issue Jan 11, 2017 · 3 comments
Closed

Firebase database ref #28

DeividasK opened this issue Jan 11, 2017 · 3 comments
Assignees
Labels

Comments

@DeividasK
Copy link

Hi,

Regarding this line: https://github.com/prescottprue/react-redux-firebase/blob/master/src/compose.js#L142
Is there any reason why you set ref to Firebase.database().ref instead of just referring to ref constant that was set above?

As it is, I cannot access this.props.firebase.ref.child(...) nor this.props.firebase.ref().child(...). If the above line is simply changed to ref, I can access database with this.props.firebase.ref.child(...).

@prescottprue prescottprue self-assigned this Jan 11, 2017
@prescottprue
Copy link
Owner

Great catch! Fixing as part of v1.1.5.

prescottprue added a commit that referenced this issue Jan 11, 2017
* `ref` is now a function in compose (Addresses #28)
* test added to confirm that `ref` is exposed correctly
* Peer Dependencies updated to include `react-redux` `^5.0.0` and ` redux` `^3.6.0`
@prescottprue
Copy link
Owner

Can you confirm that you can correctly access ref in version v1.1.5?

Want to make sure this handles your use case before closing the issue.

@DeividasK
Copy link
Author

Yes, it works now as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants