Remove deep property for REMOVE action instead of setting it to undefined #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setWith sets the value to undefined, but the key remains an enumerable property on the object. This can cause problems when your UI iterates over keys of an object and renders based on the key’s existence. Using unset, the key is removed.
fej-snikduj
force-pushed
the
v2.0.0-beta.15
branch
from
6fb1ac8
to
68fef6d
Compare
Imagine that we have a deeply nested property
`users/userId/permissions/writeAcces` = `true`. Then we call remove on
that permission. `unset` will remove the `writeAccess` property.
However, the `permissions` property will remain on the `userId` object,
*regardless* of if there are any other properties on that object. In
the case that there was no other property in `permissions`, there will
be an empty `{}` in redux-state for permissions. *However*, in
firebase - `permissions` will not even exist. By recursively unsetting
the property, we make sure the parent properties are also removed if
necessary.
|
Great work, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setWith sets the value to undefined, but the key remains an enumerable
property on the object. This can cause problems when your UI iterates
over keys of an object and renders based on the key’s existence. Using
unset, the key is removed.
Check List
If not relevant to pull request, check off as complete
Relevant Issues