Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context to Consumer instead of Provider #589

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

Rizzet
Copy link

@Rizzet Rizzet commented Dec 16, 2018

Description

Wrongly used ReactReduxFirebaseContext.Provider instead of ReactReduxFirebaseContext.Consumer generates an error from React when firebaseConnect() is used.
While firestoreConnect() is using ReactReduxFirebaseContext.Consumer this is probably only a typo.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #589 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #589   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          26       26           
  Lines         915      915           
  Branches      166      166           
=======================================
  Hits          716      716           
  Misses        199      199

@prescottprue
Copy link
Owner

prescottprue commented Dec 16, 2018

That must have been changed during a cleanup, and looks like I only checked firestoreConnect. Thanks for reporting.

@prescottprue prescottprue changed the base branch from next to v3.0.0-alpha.2 December 16, 2018 19:01
@prescottprue prescottprue merged commit 11ccaa1 into prescottprue:v3.0.0-alpha.2 Dec 16, 2018
@prescottprue
Copy link
Owner

Released in v3.0.0-alpha.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants