fix(types): make options param optional in updateProfile #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3.0.0-alpha.16 #749 +/- ##
==================================================
Coverage ? 87.03%
==================================================
Files ? 30
Lines ? 972
Branches ? 178
==================================================
Hits ? 846
Misses ? 126
Partials ? 0 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Aug 15, 2019
* fix(examples): switch to next in simple example with new version of react-redux * fix(types): make options param optional in `updateProfile` - #749 - @rscotten * feat(HOCs): remove `createFirestoreConnect` and `createFirebaseConnect` - store selection is no longer necessary * fix(types): add descriptions for main methods * fix(types): remove no longer exported functions from types * feat(tests): replace [`istanbul`](https://www.npmjs.com/package/istanbul) with [`nyc`](https://www.npmjs.com/package/nyc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the
optionsarg optional inupdateProfile.Other changes courtesy of the Prettier linter that were not reversed by running
npm run lint:fix.Check List
If not relevant to pull request, check off as complete
Relevant Issues