Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToggleSexyComments flag to enable sexy comments while toggling #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mayanksha
Copy link

Add a flag named "ToggleSexyComments" to use Sexy Comments while toggling.
This is especially useful for people who instead of using a leader key combination to comment, have a 'c' (or some else) key mapped to toggle comments on the selected line(s).

P.S. I am new to open-source and this is my first pull request. Please correct me wherever I'm wrong whether I've violated any style-guide to be followed.

@alerque
Copy link
Member

alerque commented Feb 12, 2018

Hey @mayanksha and thanks for the contribution! Off the top of my head this look good, but I"ll test it to make sure it works when I get a chance before merging.

In the mean time would you be able to add documentation for this feature to the internal vim docs file? I see you added to the README which is great, but having this documented in vim's internal help system would also be good.

@mayanksha
Copy link
Author

Hi @alerque ! I surely will update the vim documentation. I have also missed out on some edge cases which need to be handled, like the nested sexy comments. I will address them in the next commit.

I am having my exams presently, so it might take a week or so before I push another commit. Thanks!

@alerque
Copy link
Member

alerque commented Feb 15, 2018

Sure no worries @mayanksha, this will be here until it's ready.

@Ryuno-Ki
Copy link

@mayanksha Hope your exams went well!

Could you make any progress on this? Meanwhile it looks like some merge conflicts occured.

can be mapped to a single key to have even better commenting.
@kevinhwang91
Copy link
Contributor

Waiting for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants