Symlinks Not Showing as Symlinks #110
Conversation
|
Unfortunately the behavior of "resolve()" is not consistent. On my mac, vim version 7.3, the behavior is as described in the issue. However on a Solaris machine I have running vim 7.2, the behavior is different. [cperl@screed ~]$ vim --version vs. [cperl@solaris ~]$ vim --version I'll put together something for you to pull to address this. |
|
Hey, I havent forgotten about this, but if you want to send a pull request then even better :-) |
This reverts commit bc745b6. This broke symlink detection on systems where vim's resolve() removes the trailing slash from a path.
The core issue is that in some versions of vim resolve() will remove trailing slashes, while in others it will not. This lead to commit bc745b6 attempting to address a double slash problem. However, that broke symlink detection on systems where resolve() removes trailing slashes. This new function just calls vim's resolve() function, but removes trailing slashes if they exist.
Symlinks Not Showing as Symlinks
|
Cheers :) @actionshrimp can you confirm that editing network shares still works as expected since one of your commits from #78 was reverted here. |
|
The network shares seem unaffected by this - everything is still working as expected :-) |
|
Sweet, cheers :) |
Commit bc745b6 introduced code which changed how "hardPath" is calculated. Essentially it moved the addition of a "/" between the last path component and the rest of the path from s:Path.readInfoFromDisk() down into s:Path.strTrunk(). However, on my system this breaks the calculation of hardPath, as resolve() removes the trailing "/" returned by s:Path.strTrunk():
On my system, these two commands return different results:
:echo g:NERDTreeFileNode.GetSelected().path.strTrunk()
-> "/Users/cperl/tmp/2012-01-09/t/" (with trailing "/")
:echo resolve(g:NERDTreeFileNode.GetSelected().path.strTrunk())
-> "/Users/cperl/tmp/2012-01-09/t" (without trailing "/")
This means that for an example directory structure like this:
[cperl@screed ~/tmp/2012-01-09]$ tree -f -i t/
t
t/a
t/b -> a
2 directories, 0 files
hardPath for t/a becomes "/Users/cperl/tmp/2012-01-09/ta" and for t/b becomes "/Users/cperl/tmp/2012-01-09/tb". Since these are bogus paths, resolve(hardPath) will always be equal to hardPath and hence nothing will be flagged as a symlink.
Just as an example having nothing to do with NERDTree showing resolve removing the trailing slash:
:echo resolve("/foo/bar/baz/")
-> "/foo/bar/baz"