Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curly braces to the list of characters to be escaped. #1128

Merged
merged 4 commits into from May 26, 2020
Merged

Conversation

PhilRunninger
Copy link
Member

@PhilRunninger PhilRunninger commented May 21, 2020

Description of Changes

Closes #1092

The combination of the globpath() function and the fish shell requires some additional care when it comes to filename characters that need to be escaped. In particular, when a path containing curly braces is used in the globpath() function, it fails in the fish shell, but works fine in bash. If those braces are escaped, then it works in both shells.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@PhilRunninger PhilRunninger merged commit 052b1f0 into master May 26, 2020
@PhilRunninger PhilRunninger deleted the 1092 branch May 26, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory with braces does not show contents when expanded
1 participant