Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix highlight for file node #1157

Merged
merged 2 commits into from
Jul 24, 2020
Merged

fix highlight for file node #1157

merged 2 commits into from
Jul 24, 2020

Conversation

pirey
Copy link
Contributor

@pirey pirey commented Jul 24, 2020

Description of Changes

Fix for #960 #953

The issue arise because NERDTreeFile is linked to Normal highlight. This caused the file node background to be the same as whatever color Normal is using, thus the highlight is different than the cursorline.

My solution is to clear bg highlight for NERDTreeFile.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

@pirey pirey changed the title fix #960 #953 highlight for file node fix highlight for file node Jul 24, 2020
@PhilRunninger PhilRunninger self-requested a review July 24, 2020 15:09
Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It looks like this bug dependent upon which editor and color scheme you're using. I use gruvbox, and never could reproduce the issue. I had to use solarized in nvim to see your change take effect.

Thanks for figuring it out.

@PhilRunninger PhilRunninger merged commit 4a32dd0 into preservim:master Jul 24, 2020
Xuyuanp added a commit to Xuyuanp/nerdtree-git-plugin that referenced this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants