On load show which files were not loaded #1274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilRunninger
requested changes
Oct 12, 2021
There was a problem hiding this comment.
This looks good. I have just a couple of changes for you, though.
- Combine the two
nerdtree#echoWarning()statements into one, as described. - Add similar logic to
s:TreeDirNode.refresh() - Update
CHANGELOG.mdwith a reference to your PR. Use version number6.10.17.
Thanks!
| @@ -438,6 +440,7 @@ function! s:TreeDirNode._initChildren(silent) | |||
|
|
|||
| if invalidFilesFound | |||
| call nerdtree#echoWarning(invalidFilesFound . ' file(s) could not be loaded into the NERD tree') | |||
| call nerdtree#echoWarning('Invalid files: ' . join(invalidFiles, ', ')) | |||
There was a problem hiding this comment.
Combine these two nerdtree#echoWarning calls into one. Something like: 3 Invalid Files: foo.txt, bar.txt, snafu.txt
This was referenced Aug 28, 2023
Merged
|
Thanks for this. Since we didn't hear back on the minor feedback above another contributor jumped in with that little fix. The commit from this PR was included in the later one, so this is merged and thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small patch to show which files couldn't be read.