Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'b' binding to jump to bookmark table #1307

Closed
wants to merge 1 commit into from

Conversation

ds2606
Copy link
Contributor

@ds2606 ds2606 commented Apr 12, 2022

Description of Changes

Closes #1304

Adds the natural 'b' binding to jump directly to the bookmark table. This skips a lot of manual navigation to the bookmarks for users who want to use NERDTree as a way to quickly navigate to certain directories with the file explorer.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

" FUNCTION: s:jumpToBookmarks() {{{1
" moves the cursor to the bookmark listing
function! s:jumpToBookmarks() abort
try
Copy link
Member

@rzvxa rzvxa Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ds2606 Hello sir, I'm sorry to see your beautiful PR has been waiting for this long.
I'm Currently going back into old PRs to find useful unmerged ones like yours. Is there any chance that you have an interest in continuing to work on this PR?

My only issue with this code is using try/catch instead of checking whether or not the bookmark section is open via this function call:

b:NERDTree.ui.getShowBookmarks()

@@ -5,6 +5,7 @@
- **.PATCH**: Pull Request Title (PR Author) [PR Number](Link to PR)
-->
#### 6.10
- **.17**: Add 'b' binding to to jump to bookmark table. (ds2606) [#1305](https://github.com/preservim/nerdtree/pull/1305)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not doing a new version for each PR anymore, just remove this change log. For now, I'll use the PR titles to write multi-bulletin change logs.

@rzvxa
Copy link
Member

rzvxa commented May 13, 2024

Closed in favor of #1394, added you as the co author.

@rzvxa rzvxa closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump to bookmark list
2 participants