Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim 9.0 menu patch #1322

Closed
wants to merge 2 commits into from
Closed

Vim 9.0 menu patch #1322

wants to merge 2 commits into from

Conversation

santiagovrancovich
Copy link

@santiagovrancovich santiagovrancovich commented Aug 27, 2022

EDIT:

This is only open for historical reasons and to make it easier to find.

This PR is a hotfix for the issue mentioned in #1321.
There is a problem in the early versions of Vim9 which prevents some parts of NERDTree from restoring their original size after a temporary window/pane resize. This patch forces a manual resize so deal with this issue.
I suggest you update your Vim if you are experiencing this problem instead of using this patch.

TL;DR Just update your Vim!

Description of Changes

Force resize after closing the menu to prevent issue #1321


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

Forcing resize after closing the menu to prevent issue #1321
Copy link

@igbanam igbanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through this locally, and it seems to work for my Vim9 🎉

@softwaregravy
Copy link

I have tested this locally, and it is working properly for me.

# vim --version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 17 2022 21:21:22)
macOS version - arm64
Included patches: 1-217
# git head
commit fc85a6f07c2cd694be93496ffad75be126240068 (HEAD -> master, origin/master, origin/HEAD)
Author: Rod Elias <rodiney@gmail.com>
Date:   Mon Jun 13 07:10:46 2022 -0300

@dqnk
Copy link

dqnk commented Nov 3, 2022

Tested locally, works for me on Neovim 0.8.0. Please merge ASAP, because having screen real estate eaten by this bug is annoying.

Copy link

@alisherry alisherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sukima
Copy link

sukima commented Apr 15, 2023

What are the actual blockers to getting this merged and released?

@igbanam
Copy link

igbanam commented Apr 16, 2023

I think someone just needs to click the merge button. From what I remember though, NERDTree has been looking to transition its maintainer for a while. I don't know how successful that process has been

@santiagovrancovich
Copy link
Author

This issue was patched by Vim in newer versions, it just affected a few 9.0 releases, this pull request is still up so people can patch it locally if they decide to keep using older versions of Vim.

@rzvxa rzvxa changed the title Vim 9.0 menu hotfix Vim 9.0 menu patch Dec 29, 2023
@santiagovrancovich santiagovrancovich closed this by deleting the head repository Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants