Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version to 7.0.1 #1388

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Bumped version to 7.0.1 #1388

merged 1 commit into from
Dec 2, 2023

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Dec 2, 2023

I think we should release a new version at this point before merging more PRs. We already have 10 updates on this minor version.

@rzvxa rzvxa requested a review from alerque December 2, 2023 13:32
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: I would suggest Git commit messages follow the imperative tense rather than past tense: e.g. "Fix blah" not "Fixed blah". There is a lot of discussion out there about preferences but there are a lot of documented benefits to imperative. See this guide.

Personally I also like to follow conventional commits which makes it a lot easier to generate changelogs down the road.

@alerque alerque merged commit 9ec27d4 into preservim:master Dec 2, 2023
1 check passed
@rzvxa
Copy link
Member Author

rzvxa commented Dec 2, 2023

@alerque Thanks, I'll give the whole thing a read. I don't have any preference for it so I'll just switch to the imperative tense, It was my bad doing it in the past tense in the first place I should've followed the style of older commits.

As for the conventional commits, I've never set up any CI for creating changelogs using conventional commits and/or semver before, But if you don't mind we can add an action for the master branch that releases a new version. Let me know whether or not you are into this idea.

@alerque
Copy link
Member

alerque commented Dec 2, 2023

I'd be fine with some release automation, probably with some manual triggering. It could just post a new commit with an updated changelog and tag it appropriately. I would suggest git-cliff for the job if we try to automate it.

@rzvxa
Copy link
Member Author

rzvxa commented Dec 2, 2023

I'll start working on it whenever I find some free time, It may take a weekend or two for me to read all of the documentation and play around with small examples so I have to postpone it until I'm finished with my current project.
I need to test it in my own repository but I'll make sure to create a draft merge request when I've got a working version so you can give feedback on the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants