Better OSX detection #853
Merged
Better OSX detection #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdtree_plugin/fs_menu.vim
Outdated
| if has("unix") | ||
| let s:uname = system("uname") | ||
| let stat_cmd = 'stat -c "%s" ' | ||
| if s:uname == "Darwin\n" |
There was a problem hiding this comment.
Change this operator to =~? and remove the \n. The case-insensitive regex will help future-proof the if statement. See :h expr-=~?.
PhilRunninger
requested changes
Jun 15, 2018
nerdtree_plugin/fs_menu.vim
Outdated
| let stat_cmd = 'stat -f "%z" ' | ||
| else | ||
| let stat_cmd = 'stat -c "%s" ' | ||
| if has("unix") |
There was a problem hiding this comment.
Taking a wider look at this file, I noticed that this if has("unix") statement has already been done on line 41, so we don't need it again here.
PhilRunninger
approved these changes
Jun 15, 2018
|
Thanks, @bubba-h57, for the improvement. Good catch! |
|
@PhilRunninger Thanks for maintaining a great plugin that makes my life easier. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim does not support an osx feature to test for. This PR implements a more generic test for the OSX operating system in order to ensure the correct
statcommand is used.