Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlight of multiple paragraphs in list items #39

Merged
merged 2 commits into from
Oct 1, 2013

Conversation

shirosaki
Copy link
Collaborator

I tried to fix #9.

It seems to work fine with the following markdown.
https://github.com/Valloric/YouCompleteMe/blob/master/README.md

@ivotron
Copy link
Contributor

ivotron commented Jul 24, 2013

seems to work with numbered lists but not with bullet lists (-, +, etc). For example, this works:

  1. testing

    one,two

this doesn't:

  • testing

    one,two

@goerz
Copy link

goerz commented Sep 5, 2013

That's because the second definition of the mkdNonListItemBlock overwrites the first. Line 77 in the patched file should read

syn region mkdNonListItemBlock start="\n\(\_^\_$\|\s\{4,}[^ ]\|\t+[^\t]\)\@!" end="^\(\s*\([-*+]\|\d\+\.\)\s\+\)\@=" contains=@mkdNonListItem

and line 78 should be removed.

@ivotron
Copy link
Contributor

ivotron commented Sep 5, 2013

cool, I just tried it and it works perfectly :)

Catch both numbered and unnumbered lists in a regexp pattern
@shirosaki
Copy link
Collaborator Author

@goerz thank you. I've updated the patch.

@plasticboy plasticboy merged commit 276518b into preservim:master Oct 1, 2013
@plasticboy
Copy link
Collaborator

Seems to work very nicely, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple paragraphs in list items
4 participants