Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check DB connectivity before import #118

Merged
merged 1 commit into from
Oct 17, 2022
Merged

feat: check DB connectivity before import #118

merged 1 commit into from
Oct 17, 2022

Conversation

betodealmeida
Copy link
Member

Before running an import with superset sync native test the DB connectivity and warn if it fails (failure could be expected, depending on the network configuration).

@cwegener
Copy link

Works nicely! Just noticed it when I updated to latest master today. Got slightly startled on first Warning but was happy that the import completed successfully!

@betodealmeida
Copy link
Member Author

Works nicely! Just noticed it when I updated to latest master today. Got slightly startled on first Warning but was happy that the import completed successfully!

Nice! Yeah, I was expecting valid cases where this would fail as expected... but it really helps debugging in other cases.

@cwegener
Copy link

One thing I forgot to mention:

The WARNING Log message does include the cleartext password in the SQLAlchemy Engine URI.

I guess that would be an easy thing to fix?

@betodealmeida
Copy link
Member Author

One thing I forgot to mention:

The WARNING Log message does include the cleartext password in the SQLAlchemy Engine URI.

I guess that would be an easy thing to fix?

Oh, thanks for letting me know! That's not good, I'll fix it... I thought SQLAlchemy masked the password, I think I need to explicitly convert it to a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants