chore: clean get_resource
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
reviewed
Oct 26, 2022
| @@ -394,7 +394,7 @@ def get_resource(self, resource_name: str, resource_id: int) -> Any: | |||
| response = self.session.get(url) | |||
| validate_response(response) | |||
|
|
|||
| resource = response.json() | |||
| resource = response.json()["result"] | |||
There was a problem hiding this comment.
Are we okay with throwing a KeyError if result isn't available?
There was a problem hiding this comment.
Yeah, if the key is not there it's because the Superset API has completely changed, so it's OK. Also, today we'd also raise KeyError, only later in the code.
AAfghahi
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SupersetClienthas 2 methods for retrieving assets from Superset:get_resources, which returns a list of resources (eg, charts).get_resource, which returns a single resource given its ID and type.Their response is slightly different. The former returns a subset of the JSON response from Superset, containing only the actual asset (it returns
response_payload["result"]). The latter returns the full JSON response from Superset, so after the code has to call:I cleaned up the client so that only the result is returned, allowing code to be rewritten as: