Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (native): no password prompt on db update #140

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Oct 28, 2022

When doing an asset sync, if a database YAML file has a masked password (eg, postgresql://user:XXXXXXXXXX@host:5432/dbname) and the database already exists, don't prompt users for the password. We can simply pass the masked password and Superset will do the right thing.

Also fix a dataset bug I found when exporting the examples database. For some reason the params attribute in the dataset is a string:

table_name: Video Game Sales
schema: public
sql: ''
params: '{"remote_id": 64, "database_name": "examples", "import_time": 1606677834}'
...

Even though it should be an object:

https://github.com/apache/superset/blob/d3f930a5575f03bc5f4f468b8bf37e834bf2aa4d/superset/datasets/commands/export.py#L61

@betodealmeida betodealmeida merged commit d99c9ab into main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants