Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure is_active is true #165

Merged
merged 2 commits into from
Dec 13, 2022
Merged

fix: ensure is_active is true #165

merged 2 commits into from
Dec 13, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Dec 12, 2022

For some reason the CLI is pushing is_active=null to the API when updating columns, something that should never happen:

ERROR: preset_cli.lib: {"message":{"columns":{"0":{"is_active":["Field may not be null."]},"1":{"is_active":["Field may not be null."]},"2":{"is_active":["Field may not be null."]},"3":{"is_active":["Field may not be null."]},"4":{"is_active":["Field may not be null."]},"5":{"is_active":["Field may not be null."]}}}} 

I changed the CLI so that when a column has is_active set to None we remove it from the update, preserving the existing value.

@betodealmeida betodealmeida merged commit 1af3bb8 into main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasets are intermittently created with is_active set as null
3 participants