Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbt): dbt Cloud columns as the standard #197

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(dbt): dbt Cloud columns as the standard #197

merged 1 commit into from
Mar 31, 2023

Conversation

betodealmeida
Copy link
Member

The schema for column metadata used by dbt Core is slightly different from the dbt Cloud response schema. For the former:

{"columns": {"customer_id": {"name": "customer_id", "description": "some description"}}}

And for the latter:

{"columns": [{"name": "customer_id", "description": "some description"}]}

Because of this, when using dbt Cloud the column metadata was not being synced. I fixed it by setting the dbt Cloud as the standard; when reading the column metadata from the manifest in dbt Core we modify the schema to match the one in dbt Cloud.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #68582: The CLI is not syncing column descriptions from dbt Cloud.

@betodealmeida betodealmeida merged commit c5d9f99 into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants